Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set flag so the build fails on notebook errors #414

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

brian-rose
Copy link
Member

Related to #413

@brian-rose brian-rose requested a review from a team as a code owner July 12, 2023 18:12
@brian-rose brian-rose requested review from dopplershift and dcamron and removed request for a team July 12, 2023 18:12
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c2dc084
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/414

@brian-rose
Copy link
Member Author

The build is expected to fail here until the underlying issue in #413 is resolved. There may be other silent failures too that we've missed.

@brian-rose brian-rose requested a review from a team as a code owner July 12, 2023 21:48
@brian-rose
Copy link
Member Author

Pinning the environment to scipy < 1.11 which should resolve #413. I expect that tests will pass this time.

@brian-rose brian-rose requested a review from r-ford July 12, 2023 22:04
Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for figuring this out.

@r-ford r-ford merged commit c830e7d into main Jul 13, 2023
2 checks passed
@r-ford r-ford deleted the brian-rose-patch-1 branch July 13, 2023 01:28
github-actions bot pushed a commit that referenced this pull request Jul 13, 2023
jukent pushed a commit to jukent/pythia-foundations that referenced this pull request Mar 21, 2024
* Update _config.yml

* Pin to earlier scipy version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants