Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change admonitions #469

Merged
merged 3 commits into from
May 15, 2024
Merged

Change admonitions #469

merged 3 commits into from
May 15, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented May 15, 2024

With the new sphinx theme, admonitions are called like

```{admonition} Info
:class: tip

In the above code example, we are extract ...

The HTML <div> ... version was causing the issues. This is isolated to these two files and doesn't require an overall theme adjustment.

Closes ProjectPythia/sphinx-pythia-theme#64

@jukent jukent requested a review from a team as a code owner May 15, 2024 14:24
@jukent jukent requested review from ktyle and brian-rose and removed request for a team May 15, 2024 14:24
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented May 15, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 287cae8
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/469

@jukent jukent requested a review from r-ford May 15, 2024 14:25
brian-rose
brian-rose previously approved these changes May 15, 2024
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brian-rose
Copy link
Member

Link checker failure is unrelated, but we need to address that too.

@jukent
Copy link
Contributor Author

jukent commented May 15, 2024

Link checker failure is unrelated, but we need to address that too.

I just fixed one link, but there are two more that are failing to pass link-checker that aren't broken.

(core/datetime/datetime: line 200010) broken    https://ghrc.nsstc.nasa.gov/uso/ds_docs/vaiconus/vaiconus_dataset.html#a6 - HTTPSConnectionPool(host='ghrc.nsstc.nasa.gov', port=443): Max retries exceeded with url: /uso/ds_docs/vaiconus/vaiconus_dataset.html (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5cbcc04830>: Failed to establish a new connection: [Errno 101] Network is unreachable'))
(core/datetime/datetime: line 200006) broken    https://ghrc.nsstc.nasa.gov/uso/ds_docs/vaiconus/vaiconus_dataset.html - HTTPSConnectionPool(host='ghrc.nsstc.nasa.gov', port=443): Max retries exceeded with url: /uso/ds_docs/vaiconus/vaiconus_dataset.html (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5cbcd4ec60>: Failed to establish a new connection: [Errno 101] Network is unreachable'))
build finished with problems, 43 warnings.

@jukent jukent requested a review from brian-rose May 15, 2024 20:12
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jukent jukent merged commit 07bcc55 into ProjectPythia:main May 15, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General formatting issues with some notebooks
3 participants