Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Key Flags override, fixes #205 #272

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Allows Key Flags override, fixes #205 #272

merged 1 commit into from
Feb 20, 2025

Conversation

davrux
Copy link
Contributor

@davrux davrux commented Feb 14, 2025

Added InsecureAllowAllKeyFlagsWhenMissing to packet.Config.
Allows usage of keys without key flags.

Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 Thanks for the great PR and for writing tests as well! Some minor nitpicks only about the latter below.

@davrux
Copy link
Contributor Author

davrux commented Feb 20, 2025

Is there anything else I can do?

@twiss
Copy link
Member

twiss commented Feb 20, 2025

Hey 👋 Sorry for the delay. CI is complaining that "Code scanning is waiting for results from CodeQL", for some reason, so I squashed the commits in hopes that will help.

Added InsecureAllowAllKeyFlagsWhenMissing to packet.Config.
Allows usage of keys without key flags.
@twiss twiss merged commit cfbd6f6 into ProtonMail:main Feb 20, 2025
10 checks passed
@twiss
Copy link
Member

twiss commented Feb 20, 2025

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants