bitmagnet update #511
Open
bitmagnet update #511
+105
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynameisbogdan
requested changes
Jan 18, 2025
Comment on lines
-78
to
-81
| downloadvolumefactor: | ||
| text: 0 | ||
| uploadvolumefactor: | ||
| text: 1 |
There was a problem hiding this comment.
Why remove them?
aiming at sourcing every attribute from feed. If these attributes do not have defaults and are best provided, they should be reinstated
Co-authored-by: Bogdan <[email protected]>
Co-authored-by: Bogdan <[email protected]>
Co-authored-by: Bogdan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexer/Tracker
bitmagnet is a self hosted DHT crawler. It provides a torznab standards compliant interface
Current version of bitmagnet.yml cardigan definition ignores all of the extended attributes. Additionally it assumes that bitmagnet is running in same docker daemon or same physical server as Prowlarr.
This change addresses both of those issues. docker daemon / server assumption is a partial fix as cardigan indexers do not support free form definition of URL. This issue has been previously raised Prowlarr/Prowlarr#1892 and rejected. Hence need to go with a long list of locations where bitmagnet maybe hosted in a self hosted setup.
Have also created a PR against bitmagnet to improve use of generic torznab indexer. https://github.com/bitmagnet-io/bitmagnet/pull/369/files This is not well documented in Prowlarr. Have scanned code to conclude
commentselement is used to generate link to details in indexer.