-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector Extension #35
base: stage3
Are you sure you want to change the base?
Vector Extension #35
Conversation
(cherry picked from commit 27ae013)
TODO before merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Once the coalescer is fixed and there's a bit of cleanup, I think its ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a general comment on the rv32v asm files, a majority of the benchmarking files is usually the test data from what I've seen, is it reused enough that the common data can be pulled out into a helper file that each benchmark file includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of these hidden files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use the stage3 fetch so that any fixes can be shared by both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with the hazard unit, could we pull it out to be "pipeline agnostic" and enable certain parts depending on the pipeline config
Also are there any defines for the tests that I can change to have more test coverage? |
…e addr are now uncoalescable, whole $ block is only potentially written on aligned addr
Tests are passing with Will cleanup next and we should add tests for 2 cores running vector code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, nice catch on the pass through bug. The write strategy makes sense and seems to be pretty simple implementation wise.
source_code/caches/coherency_unit.sv
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, this looks good. The conditional probably isn't needed but it should be fine
…l.py change, line 53
Implement zve32x subset of the RISC-V vector extension without fixed point instructions. Documentation about this vector extension implementation is in
doc/src/rv32v
.