Skip to content

Commit

Permalink
removed some TODO and FIXME comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Athryx committed Mar 11, 2024
1 parent e0eeb7e commit 2a4e1c1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 2 additions & 4 deletions application_processor/src/attest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ fn perform_attest(driver: &mut ApDriver) -> Result<(), ApError> {
let component_id = try_get_component_id("Component ID: ")
.ok_or(ApError::InvalidInput)?;

// TODO: determine if this needs glitch protection
// this could hypothetically be glitched to attet components we are
// not provisioned with but this is not worth a flag in any scenario
// check that we are provisioned for the component we are requested to attest
if driver.get_flash_data().get_provisioned_component(component_id).is_none() {
return Err(ApError::InvalidComponentError);
}
Expand All @@ -39,7 +37,7 @@ fn perform_attest(driver: &mut ApDriver) -> Result<(), ApError> {
hmac,
};

// TODO: maybe have this response contain the component id and refuse to print if component id is wrong
// recieve encrypted attestation data
let mut response: EncryptedData<MAX_I2C_MESSAGE_LEN> = driver.send_and_receive_struct(address, &req)?;

let message = decrypt(&mut response, &ADATA_ENC_KEY)?;
Expand Down
4 changes: 3 additions & 1 deletion max78000_hal/src/uart.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ impl Write for UartWriter {
}
}

// FIXME: the uart is not actually sync
// The uart uses just atomic reads and writes to addresses, so no unsafety will be caused
// The only issue is it may be possible for characters to be skipped printing
// (if for example the is txfifo not full returns true but then someone else fills it)
unsafe impl Send for Uart {}
unsafe impl Sync for Uart {}

Expand Down

0 comments on commit 2a4e1c1

Please sign in to comment.