Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints + simple Pytest + higher precision serial #11

Merged
merged 182 commits into from
Jan 26, 2025
Merged

Type hints + simple Pytest + higher precision serial #11

merged 182 commits into from
Jan 26, 2025

Conversation

LelsersLasers
Copy link
Contributor

@LelsersLasers LelsersLasers commented Jan 15, 2025 •
edited
Loading

No description provided.

@LelsersLasers
Fixing things being double tabbed
aeef5fd
@LelsersLasers
Fixing string formatting to avoid invalid escape characters
c17d123
@LelsersLasers
Fixing import error
3725109
@LelsersLasers
unix file slash directions
ae8ac96
@LelsersLasers
Creating a super simple pytest example
c29603e
@LelsersLasers
Trying to convert to pytest
f7f6f3e 
Not sure if it is working because I don't understand how to actually test the code without all the boards
@LelsersLasers
Testing check.almost_equal()
db43eab
@LelsersLasers
Bugfix: setting up all of hil in the pytest fixture
8944f40
@LelsersLasers
Section dividers
6dc84e3
@LelsersLasers
Trying abox pytest
8e47132
@LelsersLasers
Don't need to call the functions when using pytest
a129354
@LelsersLasers
Can pass no arguments to run on all files
89cf479
@LelsersLasers
Readability/format changes
a85b82f
@LelsersLasers
Python decorator for logging HIL status
92840d1
@LelsersLasers
Typo in abox text config load
109132b 
Copied the charger template, forgot to switch it out
@LelsersLasers
Trying Pytest collector
4724f5d
@LelsersLasers
Folder rename
8471391
@LelsersLasers
< now correctly <= for the left bound
15ffd0c
@LelsersLasers
Trying Pytest main base
35f2c4f
@LelsersLasers
Confirming that non "hil" params are not effected
b7351e2
@LelsersLasers
Trying Pyest for main sdc
e52a166
@LelsersLasers
Typo: these tests don't read power
e91075b 
Result of copying and pasting without looking 🤷
@LelsersLasers
Trying Pytest system
6eb1c25
@LelsersLasers
Trying Pytest test
8fcff42 
Kinda weird because it makes no calls to HIL.check()
@LelsersLasers
Separating new Pytest scripts and old ones
2899d4d 
Can use this commit to see all the way normal tests were converted to pytest ones by looking at the modified files in scripts/
@LelsersLasers
Commenting out old code for in hil.py testing
09e43fb
@LelsersLasers
Type hinting return types and instance variables
26a6884
@LelsersLasers
Type hinting hil.py
81347b0
@LelsersLasers
Type hinting pin_mapper.py
f060d16
@LelsersLasers
Type hinting utils
e66dbbb
AdityaAsGithub
AdityaAsGithub reviewed Jan 25, 2025
View reviewed changes
Copy link
Contributor

@AdityaAsGithub AdityaAsGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these changes I'll tentatively say I approve since we are gonna rewrite the test scripts anyway.

TestBench/TestBench.ino Outdated Show resolved Hide resolved
hil/components/component.py

import hil.utils as utils
if TYPE_CHECKING:
from hil.hil import HIL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk man I didnt' think about this yet @AdityaAsGithub

hil/hil.py Show resolved Hide resolved
hil/hil.py Outdated Show resolved Hide resolved
hil/hil_devices/hil_device_arduino_micro.json Show resolved Hide resolved
AdityaAsGithub
AdityaAsGithub approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@AdityaAsGithub AdityaAsGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the stipulation that the test scripts themselves are getting rewritten soon anyway, so they don't matter for the time being.

@LelsersLasers LelsersLasers merged commit 7306e96 into master Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaAsGithub AdityaAsGithub AdityaAsGithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LelsersLasers @AdityaAsGithub