Support redis-client gem
#131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 7.0, Sidekiq uses `redis-client` by default. sidekiq/sidekiq@0b3e4c2 This patch allows to users use `health_check` without adding `redis` gem with Sidekiq >= 7.0. Fixes Purple-Devs#128.
|
Thank you for your contribution! We'll get this reviewed and tested as soon as we can |
|
@jmarchello Sorry to ping, but what do you think about this and #134? |
|
This code looks good. I'm actively working on getting our tests running again and once that's done I'll be able to test and merge this change |
|
Add when 'redis-if-present'
errors << HealthCheck::RedisHealthCheck.check if defined?(::Redis) || defined?(::RedisClient) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 7.0, Sidekiq uses
redis-clientby default. sidekiq/sidekiq@0b3e4c2This patch allows to users use
health_checkwithout addingredisgem with Sidekiq >= 7.0.Fixes #128.