Only use the venv module to create virtualenvs.
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilgamezh
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possible now as we're living in the future already (?): Python minimum version is now 3.6, which is old enough.
While it simplifies the code a lot, there may be some breakage.
If the user is passing specific options to
virtualenv, as we don't use it anymore, what to do? For that I added the possibility of passing options to thevenvmodule itself... the user may need to change something in their scripts, but at least the can keep things in control.Also I improved the README, stopped using "virtualenv" to mean "virtual environment" as it was too confusing. Being explicit now.