Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update different details now we support Py>-3.6 only #440

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Update different details now we support Py>-3.6 only #440

merged 3 commits into from
Jul 21, 2024

Conversation

facundobatista
Copy link
Member

Specifically:

  • stop defining http status codes ourselves (they are in http.server.HTTPStatus)
  • stop using datetime.utcnow() (in favor of using datetime.now(UTC))
  • simplified temp files fixtures

Fixes #429

gilgamezh
gilgamezh approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@gilgamezh gilgamezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gilgamezh gilgamezh merged commit c9ff45b into master Jul 21, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilgamezh gilgamezh gilgamezh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanups after we support only Python 3.6 or greater
2 participants
@facundobatista @gilgamezh