Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore cffi installation error" #285

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

mkniewallner
Copy link
Contributor

This reverts commit f61caa2.

cffi now supports, and provides wheels for, Python 3.13 (https://github.com/python-cffi/cffi/releases/tag/v1.17.0), so this should work as expected on 3.13.

Tested on https://github.com/mkniewallner/mkv-playground/pull/9/files where cffi was correctly installed:

Install maturin
[...]
  Collecting cffi
    Downloading cffi-1.17.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (1.5 kB)
  Collecting pycparser (from cffi)
    Downloading pycparser-2.22-py3-none-any.whl.metadata (943 bytes)
  Downloading cffi-1.17.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (479 kB)
  Downloading pycparser-2.22-py3-none-any.whl (117 kB)
  Installing collected packages: pycparser, cffi
  Successfully installed cffi-1.17.1 pycparser-2.22

This reverts commit f61caa2.

`cffi` now supports, and provide wheels for, Python 3.13
(https://github.com/python-cffi/cffi/releases/tag/v1.17.0), so this
should work as expected on 3.13.
@mkniewallner mkniewallner marked this pull request as ready for review September 6, 2024 21:55
@messense messense merged commit b234962 into PyO3:main Sep 7, 2024
32 checks passed
@mkniewallner mkniewallner deleted the unignore-cffi-install-error branch September 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants