Simplify emcc_version using -dumpversion flag #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only returns the version number and no other inforamtion.
hoodmane
commented
Feb 3, 2025
| .context("Failed to parse emcc version")?; | ||
| let version = caps.get(1).context("Failed to parse emcc version")?; | ||
| Ok(String::from_utf8(version.as_bytes().to_vec())?) | ||
| Ok(String::from_utf8(emcc.stdout)?.trim().into()) |
There was a problem hiding this comment.
I think we want to trim an optional trailing -git from the end too.
messense
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only returns the version number and no other information.