Skip to content

Commit

Permalink
Fix unicode_literals causing Python2 build to fail
Browse files Browse the repository at this point in the history
  • Loading branch information
Martin Larralde committed Mar 22, 2018
1 parent 8a6f7c4 commit bd8a547
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ install:

script:
- cd example && python setup.py develop && cd ..
- cd example_tomlgen && python setup.py tomlgen_rust -w && cd ..
- cd example_tomlgen && python setup.py tomlgen_rust -w build && cd ..
1 change: 1 addition & 0 deletions example_tomlgen/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
build/
Cargo.toml
Cargo.lock
.cargo
2 changes: 0 additions & 2 deletions setuptools_rust/tomlgen.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# coding: utf-8
from __future__ import unicode_literals

import glob
import os
import string
Expand Down

4 comments on commit bd8a547

@althonos
Copy link
Member

@althonos althonos commented on bd8a547 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fafhrd91: The unicode_literals future import made build_ext.get_ext_fullpath crash in Python 2. A new release (v0.9.1) would be nice !

@fafhrd91
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@althonos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
(I also made the CI actually build the example_tomlgen project instead of simply generating the manifest so that this issue should be detected if a regression occurs).

@fafhrd91
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is good!

Please sign in to comment.