Resolve issue in filter/validate deprecation path #3368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
@emma58 pointed out a bug in the Set filter/validate deprecation path where Scalar sets with dim=2 would silently not call filter correctly (as the deprecation path required the filter function to raise an exception or return false when called with the new syntax. This PR resolves the error and adds a test for this scenario.
In addition, @mfripp pointed out on SO that we were being rather rude deprecating an old syntax in the same release that we added support for the new API. This PR silences the deprecation warning for the (common) case where filter / validate was being used on a Scalar Set.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: