-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve buffering issues in TeeStream
and capture_output
#3449
Open
jsiirola
wants to merge
25
commits into
Pyomo:main
Choose a base branch
from
jsiirola:tee-stream-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+559
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would love to see this resolved. |
Thanks! We have been having lots of issues with our testing infrastructure that we need to fix before we can get any actually functional PRs merged. Stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3084, fixes #3031, fixes #2845.
Summary/Motivation:
The HiGHS interface exposed some issues in the logic in
TeeStream
andcapture_output
where the two could end up fighting with each other. This PR should resolve all issues with console log management that we have been seeing with HiGHS.Changes proposed in this PR:
TeeStream
handle is propagated through tho the target output streamsTeeStream
tocapture_output
to prevent ending up with nestedTeeStream
instancesTeeStream
shoulddup
all target file descriptors so that subsequent context managers (likecapture_output
) don't commandeer them (causing a weird circular reference loop)capture_output
handles redirection (do not letredirect_fd
update thesys.stdout
/sys.stderr
streams)TeeStream
(andcapture_output
)capture_output
/TeeStream
for managing the console output.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: