Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add populate feature to Player.play #300

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Add populate feature to Player.play #300

merged 6 commits into from
Apr 24, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Apr 24, 2024

Description

Adds the popluate feature back to Player.play.

If a track is successfully played, populate will search for recommendations when populate is set to True.

Added max_populate keyword argument to control the maximum amount of tracks that can be added.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@EvieePy EvieePy linked an issue Apr 24, 2024 that may be closed by this pull request
@EvieePy
Copy link
Member Author

EvieePy commented Apr 24, 2024

Also converted pyproject.toml to use ruff instead of black so it's likely all checks will fail on linting.

@AbstractUmbra
Copy link
Contributor

Approved but codebase currently doesn't meet the new ruff standards. Is this a WIP or should this branch also cover these new additions?

@EvieePy
Copy link
Member Author

EvieePy commented Apr 24, 2024

Approved but codebase currently doesn't meet the new ruff standards. Is this a WIP or should this branch also cover these new additions?

Ya I just added the workflow in this branch by accident so it's failing. I will runn ruff now if everything else looks fine, I just didn't run it due to it probably changing a tonne

@EvieePy EvieePy merged commit ffcf13a into main Apr 24, 2024
3 checks passed
@EvieePy EvieePy deleted the feature/populate branch April 24, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto_queue not popularing when running wavelink.Player.play
2 participants