Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At triangulation step we must check that active neighbors are bipolar #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galoko
Copy link

@galoko galoko commented Aug 20, 2024

Hi!

I’ve been working with your SurfaceNets implementation and found it to be very insightful. While integrating it into my project, I noticed an opportunity to enhance the mesh generation process.

I propose a small enhancement to ensure that quads are formed only when edges meet a critical condition—where they truly represent a transition across the isosurface boundary (bipolar condition). This check will help prevent the formation of non-representative quads, thus increasing the accuracy of the mesh.

I believe this modification maintains the integrity of your original implementation while improving its applicability for precise surface representation.

Thank you for considering this enhancement.

@galoko galoko force-pushed the bipolar_check_fix branch from 8f582f6 to 940e657 Compare August 20, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant