Fix #1007: strcpy requires the number of chars not bytes

QL-Win · Oct 18, 2021 · e640a8b · e640a8b
1 parent fe6dae6
commit e640a8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/QuickLook.Native/QuickLook.Native32/DOpus.cpp b/QuickLook.Native/QuickLook.Native32/DOpus.cpp
@@ -103,7 +103,7 @@ void DOpus::ParseXmlBuffer(PWCHAR buffer)
 		auto b = new WCHAR[size];
 		MultiByteToWideChar(CP_UTF8, MB_ERR_INVALID_CHARS, path, -1, b, size);
 
-		wcscpy_s(buffer, MAX_PATH_EX, b); // DOpus supports Long Path
+		wcscpy_s(buffer, wcslen(b) + 1, b); // DOpus supports Long Path
 
 		delete[] b;
 		return; // we now cares only the first result

diff --git a/QuickLook.Native/QuickLook.WoW64HookHelper/QuickLook.WoW64HookHelper.cpp b/QuickLook.Native/QuickLook.WoW64HookHelper/QuickLook.WoW64HookHelper.cpp
@@ -90,14 +90,14 @@ void GetCurrentSelection()
 	if (hMapFile == nullptr)
 		return;
 
-	auto buffer = static_cast<PWCHAR>(MapViewOfFile(hMapFile, FILE_MAP_ALL_ACCESS, 0, 0, MAX_PATH * sizeof WCHAR));
+	auto buffer = static_cast<PWCHAR>(MapViewOfFile(hMapFile, FILE_MAP_WRITE, 0, 0, 0));
 	if (buffer == nullptr)
 	{
 		CloseHandle(hMapFile);
 		return;
 	}
 
-	wcscpy_s(buffer, MAX_PATH_EX, dllBuffer);
+	wcscpy_s(buffer, wcslen(dllBuffer) + 1, dllBuffer);
 
 	UnmapViewOfFile(buffer);
 	CloseHandle(hMapFile);