Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deterministic-unit_test_estimators on mac in ci #5311

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Feb 10, 2025

Proposed changes

deterministic-unit_test_estimators has a 100% fail rate on mac ci

As far as I know there is no hint of either a full diagnosis or a solution; the problem is not seen elsewhere including other arm systems.

After such a long time I think the merit of having a passing CI exceeds the merit of having the mac ci fail, which results in a red check mark for every PR. If we merge this PR, I'll add a fresh issue on the mac problem.

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None. Check for scripting errors.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • Yes/No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • Yes/No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Feb 10, 2025

Test this please

@ye-luo ye-luo enabled auto-merge February 10, 2025 22:23
@ye-luo ye-luo merged commit 1037b3b into QMCPACK:develop Feb 10, 2025
39 checks passed
@prckent
Copy link
Contributor Author

prckent commented Feb 10, 2025

Updated #4287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants