fix potential null pointer error

Qihoo360 · Jan 18, 2018 · a72d3ce · a72d3ce
1 parent 2474a40
commit a72d3ce
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/node/zp_binlog_sender.cc b/src/node/zp_binlog_sender.cc
@@ -253,16 +253,16 @@ Status ZPBinlogSendTaskPool::AddNewTask(const std::string &table_name,
     RemoveTask(task_ptr->name());
   }
   s = AddTask(task_ptr);
-  if (!s.ok()) {
-    delete task_ptr;
-  }
   LOG(INFO) << "Add BinlogTask for Table:" << task_ptr->name()
     << ", partition: " << task_ptr->partition_id()
     << ", target: " << task_ptr->node()
     << ", sequence: " << task_ptr->sequence()
     << ", filenum: " << task_ptr->filenum()
     << ", ioffset: " << task_ptr->offset()
     << ", result: " << s.ToString(); 
+  if (!s.ok()) {
+    delete task_ptr;
+  }
   return s;
 }