Skip to content

Commit

Permalink
Allow mcrx, mcry and mcrz gate methods to accept angles of ParameterV…
Browse files Browse the repository at this point in the history
…alueType (#13507)

* allow mcrx, mcry and mcrz accept angles of ParamterValueType

* update MCPhase gate definition using mcrz where the angle is of ParameterValueType

* remove annotated from control function in rx, ry, rz

* fix mc without annotation test

* add a test for mcrx/mcry/mcrz/mcp with Parameter

* add release notes

* update release notes

* simplify _mscu2_real_diagonal code into one function

* update release notes following review

* move multi_control_rotation_gates to the synthesis library

* replace MCXVChain by synth_mcx_dirty_i15. remove ctrl_state which is not used.

* add num_controls=1 in synth_mcx_dirty_i15.

* disable cyclic imports

* add to_gate to prevent test from failing

* updates following review

* minor fix

* minor fix following review

* better docs for mcrx, mcry, mcrz

* remove pylint disable
  • Loading branch information
ShellyGarion authored Jan 8, 2025
1 parent 586d72d commit 1cfdf2e
Show file tree
Hide file tree
Showing 13 changed files with 455 additions and 462 deletions.
1 change: 0 additions & 1 deletion qiskit/circuit/library/standard_gates/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
from .y import YGate, CYGate
from .z import ZGate, CZGate, CCZGate
from .global_phase import GlobalPhaseGate
from .multi_control_rotation_gates import mcrx, mcry, mcrz


def get_standard_gate_name_mapping():
Expand Down
Loading

0 comments on commit 1cfdf2e

Please sign in to comment.