Improve qiskit.circuit.QuantumCircuit page #13300
Open
+334
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
|
One or more of the following people are relevant to this code:
|
abbycross
added
the
documentation
abbycross
commented
Oct 8, 2024
Pull Request Test Coverage Report for Build 12834300454Details
💛 - Coveralls |
Co-Authored-By: Kaelyn Ferris <[email protected]>
qiskit/circuit/quantumcircuit.py
Outdated
Comment on lines
1217
to
1225
| from qiskit import QuantumRegister, ClassicalRegister, QuantumCircuit | ||
|
|
||
| q = QuantumRegister(2) | ||
| c = ClassicalRegister(2) | ||
| qc = QuantumCircuit(q, c) | ||
|
|
||
| qc.metadata = {'experiment_type': 'Bell state experiment'} | ||
|
|
||
| print(qc.metadata) |
There was a problem hiding this comment.
Same here as with .name. Also, do you know if this is needed since you've also added an example in metadata property? I'm not sure how it works
There was a problem hiding this comment.
I'm not sure! I'll do it just for the sake of practicing rewriting the code to your suggestion...
qiskit/circuit/quantumcircuit.py
Outdated
Comment on lines
1363
to
1371
| from qiskit.circuit.library import GroverOperator, Diagonal | ||
| from qiskit.providers.fake_provider import GenericBackendV2 | ||
| from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager | ||
|
|
||
| # Create circuit to test transpiler on | ||
| oracle = Diagonal([1] * 7 + [-1]) | ||
| qc = QuantumCircuit(3) | ||
| qc.h([0, 1, 2]) | ||
| qc = qc.compose(GroverOperator(oracle)) |
There was a problem hiding this comment.
Nice example! Just a suggestion for a simpler circuit
Suggested change
| from qiskit.circuit.library import GroverOperator, Diagonal | |
| from qiskit.providers.fake_provider import GenericBackendV2 | |
| from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager | |
| # Create circuit to test transpiler on | |
| oracle = Diagonal([1] * 7 + [-1]) | |
| qc = QuantumCircuit(3) | |
| qc.h([0, 1, 2]) | |
| qc = qc.compose(GroverOperator(oracle)) | |
| from qiskit.providers.fake_provider import GenericBackendV2 | |
| from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager | |
| # Create circuit to test transpiler on | |
| qc = QuantumCircuit(3) | |
| qc.h([0, 1, 2]) |
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
|
One or more of the following people are relevant to this code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add code examples where useful, and copyedit if necessary; closes #13299
Add examples for
Moving the rest to a new PR to break up the work in more manageable pieces!