-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.3.0 release #13447
Prepare 1.3.0 release #13447
Conversation
One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good stuff! let me know if you have any questions!
releasenotes/notes/1.3/add-more-sabre-trials-9b421f05d2f48d18.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/add-gates-to-collect-clifford-af88dd8f7a2a4bf9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/add-gates-to-collect-clifford-af88dd8f7a2a4bf9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/binary-arithmetic-gates-6cd2b1c8112febe0.yaml
Outdated
Show resolved
Hide resolved
2c63b31
to
bdd938a
Compare
I have checked all release notes to the best of my abilities now. @beckykd feel free to further review these. I should be posting the prelude release note sometime tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm through everything! Thanks for putting them all together and doing that initial edit!
releasenotes/notes/1.3/deprecate-pulse-package-07a621be1db7fa30.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/deprecate-pulse-package-07a621be1db7fa30.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/deprecate-pulse-package-07a621be1db7fa30.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/deprecate-pulse-package-07a621be1db7fa30.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/deprecate-pulse-package-07a621be1db7fa30.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the term "inlined" means. Can you rephrase?
"inlined onto the base circuit"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's just mentioning how it's realigning new instructions onto a base circuit. Maybe the word re-align works better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Inline" is a compiler term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also I think that note is from some prior release?
6dffa85
to
b1e08f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I've done a quick first pass through the notes but I still need to read the rendered output in sphinx to see how the complete notes read. From this first pass though I have a few concerns before I feel this is ready to merge and subsequently tagging the release.
The first is there are some notes that are already published on prior releases we need to delete those files from the stable/1.3
branch in this PR to avoid duplicating them. You can just git rm
these files, but please do an audit of all the notes in the rendered output to make sure none exist on https://docs.quantum.ibm.com/api/qiskit/release-notes/1.2 or https://docs.quantum.ibm.com/api/qiskit/release-notes/1.1
The second large concern is around how we're documenting performance improvements. We are very inconsistent about how we're reporting speedups across the board. A lot of synthesis functions are called out individually as having been ported to rust and citing a speedup factor. While for the transpiler passes only some do this, the basis translator stands out prominently as being one of the few that did this. If we're going to call these out as feature notes we should be consistent and ensure we do it for all of them. Or if we feel it's not important to document them individually as a long list it is probably better to consolidate the multiple notes into a single note for passes that lists out the passes we've ported to rust and they're generally faster. We should do the same thing for synthesis functions too. Personally I think a single large note documenting all of them is better for readers than doing a lot of small notes.
A smaller thing is I feel like many release notes were not checked over for completeness or correct categorization and we should ensure this is all correct before publishing the release notes.
releasenotes/notes/1.3/backend-sampler-v2-level1-dc13af460cd38454.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/backend-sampler-v2-level1-dc13af460cd38454.yaml
Outdated
Show resolved
Hide resolved
5669ca3
to
bbe57f2
Compare
releasenotes/notes/1.3/deprecate-basic-simulator-configuration-9d782925196993e9.yaml
Outdated
Show resolved
Hide resolved
743ff0e
to
98324b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating things. I started with the updated prelude, it is looking much better. Just have some small wording suggestions or missing details in suggestions
- Move loose release notes.
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Julien Gacon <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]> Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
…-9d782925196993e9.yaml
Co-authored-by: Julien Gacon <[email protected]>
Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: Alexander Ivrii <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
a0b7460
to
eae5da2
Compare
releasenotes/notes/1.1/fix-apply-layout-duplicate-negative-indices-cf5517921fe52706.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.1/fix-swap-router-layout-f28cf0a2de7976a8.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.1/fix-symbolic-unit-scaling-c3eb4d9be674dfd6.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.1/plot-circuit-layout-5935646107893c12.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/deprecate-basic-simulator-configuration-9d782925196993e9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/1.3/oxidize-transpiler-passes-16f2f1c57612e74a.yaml
Outdated
Show resolved
Hide resolved
- Restored some deleted release notes. - Fix formatting issues.
5cf7a5b
to
7f94f9b
Compare
Due to how we end up branching 1.2.0 without a tag this is confusing reno's version detection because on the stable/1.3 branch there is no tag before 1.3.0b1 associated with any of the release notes for 1.2.0. This commit just removes all the release notes to fix this. Additionally, this corrects the earliest-version field in the sphinx directive for reno so we include the notes associated with 1.3.0b1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, while probably not perfect (no release's documentation is ever perfect) it's definitely looking really good to me now.. Thanks for all the work on polishing it and updating all the notes and also shepherding the 1.3.0 release.
Summary
The following commits set the version number on
stable/1.3
to1.3.0
in preparation for the1.3.0
final release.Details and comments
The following commits will:
1.3.0
.releasenotes/notes/1.3/
folder.cargo
dependencies.releasenotes/notes/1.3/
.