Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom basis gates deprecation warning in generate_preset_pass_manager (backport #13460) #13462

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 20, 2024

Summary

Small improvements on custom basis gates deprecation message for generate_preset_pass_manager:

  • fixed missing space that lead to "providecustom" instead of "provide custom"
  • replaced "custom" with "non-standard" and added an explicit mention to the gate that triggers the deprecation warning after @Cryoris getting the message triggered with ccp and not being able to pinpoint why (it's not custom, but also not standard).

Details and comments


This is an automatic backport of pull request #13460 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner November 20, 2024 13:15
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: None Do not include in changelog label Nov 20, 2024
@github-actions github-actions bot added this to the 1.3.0 milestone Nov 20, 2024
@ElePT ElePT enabled auto-merge November 20, 2024 13:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11934164028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.008%) to 88.925%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 92.12%
crates/qasm2/src/lex.rs 4 91.98%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 11909933211: -0.008%
Covered Lines: 79062
Relevant Lines: 88909

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Nov 20, 2024
Merged via the queue into stable/1.3 with commit 3b8f523 Nov 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants