Fix 4-pi periodicity of controlled rotations in the CommutationChecker (backport #13670)

[mergify]

Summary

The commutation checker currently wrongly assumes that the controlled Pauli rotations CRX/Y/Z are equivalent to the identity for multiples of $2\pi$. However, this is only true for $4\pi$. Note that CP is indeed $2\pi$ periodic.

Details and comments

The tests were modified to compare the output of the commutation checker to a numeric result instead of a hardcoded one, such that this error shouldn't arise in the future again.

---

This is an automatic backport of pull request #13670 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of dffc2df has failed:

On branch mergify/bp/stable/1.3/pr-13670
Your branch is up to date with 'origin/stable/1.3'.

You are currently cherry-picking commit dffc2df6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/fix-4pi-periodic-commutations-3b89d1813513f613.yaml
	modified:   test/python/circuit/test_commutation_checker.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   crates/accelerate/src/commutation_checker.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[Cryoris]

This PR requires to backport #13677 first (which we should've backported anyways but forgot). Once #13677 is merged, this might require some merge conflict resolution but all tests should pass then.

[mtreinish]

@Mergifyio rebase

[mergify]

rebase

☑️ Nothing to do

• -conflict [📌 rebase requirement]
• -closed [📌 rebase requirement]
• queue-position = -1 [📌 rebase requirement]
• any of:
  • #commits-behind > 0 [📌 rebase requirement]
  • #commits > 1 [📌 rebase requirement]
  • -linear-history [📌 rebase requirement]

[Cryoris]

I did a manual merge since the rebase didn't seem to work due to the conflict 🙂

[coveralls]

Pull Request Test Coverage Report for Build 12816910695

Details

• 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
• 15 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.009%) to 88.923%

---

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	3	92.48%
crates/qasm2/src/parse.rs	12	97.15%

Totals
Change from base Build 12816206533:	-0.009%
Covered Lines:	79184
Relevant Lines:	89048

---

💛 - Coveralls