Unbox the DAGCircuit::op_nodes iterator
#13680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: None
|
One or more of the following people are relevant to this code:
|
This allows the iterator to be (reliably) properly monomorphised into its usage sites. Since the dynamic `include_directives` call is almost certainly given as a literal, I would strongly expect that even the trivial overhead of the short-circuiting `||` operator will be compiled out in all cases.
jakelishman
force-pushed
the
unbox-op_nodes
branch
from
56382d6 to
c0fcf89
Compare
Pull Request Test Coverage Report for Build 12828837125Details
💛 - Coveralls |
kevinhartman
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the iterator to be (reliably) properly monomorphised into its usage sites. Since the dynamic
include_directivescall is almost certainly given as a literal, I would strongly expect that even the trivial overhead of the short-circuiting||operator will be compiled out in all cases.Summary
Details and comments