Deprecate BasicSimulator.run_experiment
#13750
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
ElePT
added
the
Changelog: Deprecation
Cryoris
reviewed
Jan 29, 2025
releasenotes/notes/deprecate-run-experiment-f37b3f35724bc6bb.yaml
Outdated
Show resolved
Hide resolved
eliarbel
previously approved these changes
Jan 29, 2025
| message=r".+qiskit\.providers\.basic_provider\.basic_simulator\..+", | ||
| ) | ||
| for experiment in qobj.experiments: | ||
| result_list.append(self.run_experiment(experiment)) |
There was a problem hiding this comment.
In normal circumstances, we would probably want to have an internal _run_experiment and avoid using catch_warnings but this is all going be removed soon anyway.
releasenotes/notes/deprecate-run-experiment-f37b3f35724bc6bb.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Julien Gacon <[email protected]>
ElePT
commented
Jan 29, 2025
releasenotes/notes/deprecate-run-experiment-f37b3f35724bc6bb.yaml
Outdated
Show resolved
Hide resolved
Cryoris
approved these changes
Jan 30, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The method wasn't used in any test but was part of the public API. It gets removed in #13743.
Details and comments