Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub pipeline to look like libqasm's one. #508

Closed
wants to merge 11 commits into from
4 changes: 4 additions & 0 deletions .github/actions/cpp-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,13 @@ runs:
shell: ${{ inputs.shell }}
- name: Get latest CMake
uses: lukka/get-cmake@latest
# We clean the Conan cache as a preventive measure for our runs in self-hosted runners
# Self-hosted runners use containers that cache Conan packages from previous runs,
# and that can cause different type of problems
- name: Configure and build
run: |
conan profile detect --force
conan remove -c "*/*"
conan_profile=${{ inputs.conan_profile }}
lowercase_conan_profile=$(echo ${conan_profile} | tr '[:upper:]' '[:lower:]')
conan build . -pr=conan/profiles/${lowercase_conan_profile} -b missing
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ jobs:
echo "${conan_installation_folder}" >> $GITHUB_PATH
- name: Build wheel
run: |
conan remove -c "*/*"
/opt/python/${{ matrix.cpython_version }}/bin/python setup.py bdist_wheel
/opt/python/${{ matrix.cpython_version }}/bin/python -m auditwheel repair pybuild/dist/*.whl
- name: Wheel path
Expand Down Expand Up @@ -158,7 +159,7 @@ jobs:
echo "${conan_installation_folder}" >> $GITHUB_PATH
- name: Build wheel
run: |
conan remove -c "libqasm/*"
conan remove -c "*/*"
/opt/python/${{ matrix.cpython_version }}/bin/python setup.py bdist_wheel
/opt/python/${{ matrix.cpython_version }}/bin/python -m auditwheel repair pybuild/dist/*.whl
- name: Wheel path
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Test
on:
push:
branches:
- olafs_git_hub_pipeline
- develop
pull_request:

jobs:
Expand Down Expand Up @@ -64,10 +64,8 @@ jobs:
conan_profile: tests-${{ matrix.build_type }}-msvc-windows-x64
shell: bash

# We are observing an internal compiler error when building with gcc
# So we are changing to clang for the Linux/ARM64 builds
cpp-linux-arm64:
name: "C++ tests (clang/Linux/ARM64)"
name: "C++ tests (gcc/Linux/ARM64)"
runs-on: [self-hosted, ARM64, Linux]
container: python:3.11
strategy:
Expand All @@ -85,14 +83,15 @@ jobs:
# We are having problems when using the m4 and zulu-opendjk Conan packages on an armv8 architecture
# m4 is required by flex/bison and zulu-openjdk provides the Java JRE required by the ANTLR generator
# So, for the time being, we are installing flex/bison and java manually for this platform
- name: Install bison, flex and java
- name: Install dependencies
run: |
apt-get update
apt-get install -y bison flex default-jre
shell: bash
- uses: ./.github/actions/cpp-tests
with:
build_type: ${{ matrix.build_type }}
conan_profile: tests-${{ matrix.build_type }}-clang-linux-arm64
conan_profile: tests-${{ matrix.build_type }}-gcc-linux-arm64
shell: bash

cpp-macos-arm64:
Expand Down
1 change: 1 addition & 0 deletions conan/profiles/tests-debug-gcc-linux-arm64
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include(tests-debug)
4 changes: 4 additions & 0 deletions conan/profiles/tests-release-gcc-linux-arm64
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
include(tests-release)

[conf]
tools.build:cxxflags=["-Wno-error=maybe-uninitialized"]
1 change: 1 addition & 0 deletions test/v1x/python/test_condex.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ def test_condex_cnot(self):

ql.set_option('mapper', 'no')

@unittest.skip("disabled. Pending of issue 498 to be fixed: https://github.com/QuTech-Delft/OpenQL/issues/498")
def test_condex_toffoli_compos_gate(self):
# Check whether condex works with conditional Toffoli gate
# which is to be decomposed by toffoli decomposition parameters
Expand Down