Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CQT-259] Integrate wait and barrier directives in cQASMv1 exporter #407

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

[CQT-259] Integrate wait and barrier directives in cQASMv1 exporter #407

wants to merge 17 commits into from

Conversation

elenbaasc
Copy link
Collaborator

  • Restore SGMQ notation for barrier links.
  • Add tests for barrier links.
  • Add CHANGELOG (and entry).

@elenbaasc
Restore SGMQ notation for barrier links.
38ce5b7 
Add tests for barrier links.
rturrado
rturrado reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work. Just some minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
test/exporter/test_cqasmv1_exporter.py Outdated Show resolved Hide resolved
rturrado
rturrado requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested merging the barrier groups as a post processing, in order to keep the visitor as clean as possible.

opensquirrel/passes/exporter/cqasmv1_exporter.py Show resolved Hide resolved
test/exporter/test_cqasmv1_exporter.py Outdated Show resolved Hide resolved
test/exporter/test_cqasmv1_exporter.py Outdated Show resolved Hide resolved
test/exporter/test_cqasmv1_exporter.py Outdated Show resolved Hide resolved
test/exporter/test_cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
rturrado
rturrado reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of comments.

opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
opensquirrel/passes/exporter/cqasmv1_exporter.py Outdated Show resolved Hide resolved
elenbaasc and others added 4 commits January 10, 2025 09:52
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
56827a9 
Co-authored-by: Roberto Turrado Camblor <[email protected]>
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
d4b7b28 
Co-authored-by: Roberto Turrado Camblor <[email protected]>
@elenbaasc
Fix regex module.
0c70f25 
Add test to check for double digit registers.
Reinstate removing trailing lines and leaving one as the final step.
@elenbaasc
Revert actions-poetry from v4 to v3 so the pipeline can run.
7976aab
@elenbaasc elenbaasc requested a review from rturrado January 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyPuts GuyPuts Awaiting requested review from GuyPuts

@juanboschero juanboschero Awaiting requested review from juanboschero

@rturrado rturrado Awaiting requested review from rturrado

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenbaasc @rturrado