Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QNEBE-640] Readthedoc fix #37

Merged
merged 5 commits into from
Jul 27, 2023
Merged

[QNEBE-640] Readthedoc fix #37

merged 5 commits into from
Jul 27, 2023

Conversation

QFer
Copy link
Contributor

@QFer QFer commented Nov 11, 2022

  • Readthedoc is generated again without blocking errors

@QFer QFer requested a review from bvdvecht November 11, 2022 13:24
cmvanb
cmvanb reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@cmvanb cmvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working with python 3.8.16.

Curious why the build directory changed? The underscored directory name is not gitignored, so it will pollute the git index. Can we revert it to build?

docs/Makefile Show resolved Hide resolved
@QFer QFer force-pushed the fix/qnebe-640/readthedoc branch from 4127d72 to 485b305 Compare July 21, 2023 13:03
cmvanb
cmvanb approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@cmvanb cmvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cmvanb
cmvanb approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@cmvanb cmvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(more approval!)

@QFer QFer merged commit 72a0a02 into develop Jul 27, 2023
7 checks passed
@QFer QFer deleted the fix/qnebe-640/readthedoc branch July 27, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmvanb cmvanb cmvanb approved these changes

@bvdvecht bvdvecht Awaiting requested review from bvdvecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QFer @cmvanb