Fix LAST instrs logs #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #55
While debugging I found that the names of the last logs were not correct because the renaming of the logs and the copying to the LAST directory happened in two separate places (the first in NetQASM and the second one in SquidASM). Due to this they were executed in the wrong order and the logs were copied to LAST before they were renamed.
I moved these calls to NetQASM and also made a PR for SquidASM to remove the calls there (see PR: QuTech-Delft/squidasm#29). I chose to move them all to NetQASM instead of moving them all to SquidASM because it seems to me that this introduces the least breaking changes between different versions. With this method if you are running an older version of SquidASM then everything should still work fine since NetQASM will just overwrite the erroneous log files created by SquidASM.
If there are other reasons to prefer moving them to SquidASM instead I am also open for that as well but then we do need to keep in mind that this new version of SquidASM will no longer work with older versions of NetQASM and vice versa.