Fix connection getting flushed during exception handling #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thom747
force-pushed
the
dont-flush-on-exception
branch
from
d1ec609 to
e5ed021
Compare
bvdvecht
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a connection's
__exit__method is called due to an exception, the connection first flushes all its pending instructions in a blocking manner.In practice, this means that exceptions are delayed until whatever is on the other end of the exception has completed its subroutine and returns the results.
Depending on whatever is on the other end of the connection, this could take up to an infinite amount of time.
This PR fixes this behaviour by adding a flag to the
closemethod that makes it skip flushing during exception handling.