Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30 implement qoala runtime #74

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

30 implement qoala runtime #74

wants to merge 23 commits into from

Conversation

dieriver
Copy link
Collaborator

This PR contains the changes for the NetQASM 2.0 release

Bart van der Vecht and others added 23 commits June 17, 2022 11:54
First work on qoala runtime
ac3cd13
First work on qoala runtime
e04dd60
Fix lint
eb58380
Merge branch '30-implement-qoala-runtime' of https://github.com/QuTec…
3ec18f2 
…h-Delft/netqasm into 30-implement-qoala-runtime
Add convenience methods for registers
517f9a9
Merge branch 'release-0.12' into 30-implement-qoala-runtime
abba066
Fix lint
0b041a7
Allow registers in rotation instructions
294067f
Allow 'input' and 'output' for load/store addresses
baf7f6c
Add mul and div instructions
b274c72
@AtakTalay
Added Quot and Rem Instructions and made the necessary changes for th…
45d80f7 
…e executor
@AtakTalay
quick fix
1b44726
@AtakTalay
reverted qout => div
ce3d5e8
@AtakTalay
reverted quot => div
b3ddd76
@AtakTalay
Merge branch '30-implement-qoala-runtime' of https://github.com/AtakT…
3de0394 
…alay/netqasm into 30-implement-qoala-runtime
@AtakTalay
quick id fix
26510c1
@bvdvecht
Merge pull request #58 from AtakTalay/30-implement-qoala-runtime
a21cfbc 
Add rem instruction
@AtakTalay
Trapped Ion Flavour
7f41b4a
@AtakTalay
relative import -> absolute import
7efb6d0
@bvdvecht
Merge pull request #59 from AtakTalay/30-implement-qoala-runtime
08eabf9 
Trapped Ion Flavour
Don't replace constants in trapped ion instructions
75353cb
fix lint
8d8f244
@dieriver
Merge branch 'develop' into 30-implement-qoala-runtime
3e1ec1c 
# Conflicts:
#	netqasm/lang/instr/flavour.py
#	netqasm/sdk/connection.py
@bvdvecht bvdvecht self-requested a review September 24, 2024 13:09
bvdvecht
bvdvecht approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@bvdvecht bvdvecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thom747
Thom747 reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Thom747 Thom747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle these changes look fine to me, but without documentation on what it is you are trying to achieve, I find it hard to say whether they actually do what you intend them to do.
For instance, from the notes from our previous meetings I can see that NetQASM 2.0 would only include local instructions, with entanglement instructions using an RPC mechanism.
However, I see none of that in this PR. Is that still coming later?
More generally, can you explain what this PR does and where it fits into the larger picture?

@dieriver
Copy link
Collaborator Author

dieriver commented Oct 3, 2024

Thom.
We will work on your points, especially on adding documentation to explain the position of this PR, and what is the scope of it.
In the next update, I hope we can resolve all your questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thom747 Thom747 Thom747 left review comments

@bvdvecht bvdvecht bvdvecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dieriver @bvdvecht @Thom747 @AtakTalay