Bugfix depolarise link models multithread variant #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkvanhooft
commented
Oct 21, 2024
mkvanhooft
commented
- Fixes for depolarise and linear depolarise models in multithread variant
- Create LinearDepolariseModelParameters object for LinearDepolariseMagicDistributor
- Remove state_delay parameter when initializing DepolariseMagicDistributor and specify state_delay via cycle_time of DepolariseModelParameters in network construction for Multithread variant
- Create tests for link noise models and hardware models in multithread variant
* Fixes for depolarise and linear depolarise models in multithread variant * Create LinearDepolariseModelParameters object for LinearDepolariseMagicDistributor * Remove state_delay parameter when initializing DepolariseMagicDistributor and specify state_delay via cycle_time of DepolariseModelParameters in network construction for Multithread variant * Create tests for link noise models and hardware models in multithread variant
bvdvecht
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.