Merge pull request #43 from QuaNilo/velez

Removed useless classes, removed unused imports
QuaNilo · Dec 3, 2023 · 6ec9e4a · 6ec9e4a
2 parents 08c7950 + c465339
commit 6ec9e4a
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 46 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -26,7 +26,6 @@ jobs:
       - name:  Run Unit Tests
         run: ./gradlew test
 
-
       - name: Send Discord notification
         uses: stegzilla/discord-notify@v2
         with:
@@ -36,4 +35,3 @@ jobs:
           include_image: true
           username: 'Yo mama'
           avatar_url: 'https://i.pinimg.com/originals/a8/91/8a/a8918a2421977089bc5c167158cff466.png'
-
diff --git a/app/src/main/java/com/example/TPSIMobileProjecto/BackendData.kt b/app/src/main/java/com/example/TPSIMobileProjecto/BackendData.kt
@@ -4,7 +4,6 @@ import retrofit.TickerDetails
 import retrofit.TickerSummary
 import retrofit2.Response
 import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.launch
 import retrofit.RetrofitHelper
 import retrofit.retrofitInterface
 import kotlinx.coroutines.Dispatchers
@@ -103,11 +102,11 @@ class BackendData {
             val symbolSummaryList = mutableListOf<TickerSummary>()
             val tickersList = getTickersList()
 
-            if (tickersList.isNullOrEmpty()) {
+            if (tickersList.isEmpty()) {
                 Log.e("MyTag: ", "Failed to fetch details for ticker: $tickersList")
                 return emptyList()
             }
-            for (ticker in tickersList!!) {
+            for (ticker in tickersList) {
                 val responseSymbolSummary: Response<TickerSummary> =
                     tickersAPI.getSymbolSummary(ticker)
                 if (responseSymbolSummary.isSuccessful) {
@@ -116,7 +115,6 @@ class BackendData {
                         symbolSummaryList.add(tickerSummary)
                     }
                 } else {
-                    // Handle the error, log it, or throw a custom exception
                     Log.e("MyTag: ", "Failed to fetch summary for ticker: $ticker")
                 }
             }

diff --git a/app/src/main/java/com/example/TPSIMobileProjecto/ui/News/NewsFragment.kt b/app/src/main/java/com/example/TPSIMobileProjecto/ui/News/NewsFragment.kt
@@ -14,7 +14,6 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import com.example.TPSIMobileProjecto.R
 import com.example.TPSIMobileProjecto.databinding.FragmentNewsBinding
-import com.example.TPSIMobileProjecto.ui.home.stockFragments.checklist.ChecklistRecyclerAdapter
 
 class NewsFragment : Fragment() {
     private lateinit var itemAdapter : NewsRecyclerAdapter

diff --git a/app/src/main/java/com/example/TPSIMobileProjecto/ui/home/HomeFragment.kt b/app/src/main/java/com/example/TPSIMobileProjecto/ui/home/HomeFragment.kt
@@ -6,7 +6,6 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
-import androidx.lifecycle.ViewModelProvider
 import com.example.TPSIMobileProjecto.databinding.FragmentHomeBinding
 import com.example.TPSIMobileProjecto.ui.home.stockFragments.simpleCard.SimpleCardFragment
 import com.example.TPSIMobileProjecto.R
@@ -28,7 +27,6 @@ class HomeFragment : Fragment(){
     ): View {
 
         Log.e("Lifecycle", "HomeFragment onCreateView()")
-        val homeViewModel = ViewModelProvider(this).get(HomeViewModel::class.java)
 
         _binding = FragmentHomeBinding.inflate(inflater, container, false)
         val root: View = binding.root
@@ -37,8 +35,7 @@ class HomeFragment : Fragment(){
             .addToBackStack(null)
             .commit()
         return root
-
-
+
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
@@ -70,6 +67,7 @@ class HomeFragment : Fragment(){
     override fun onResume() {
         super.onResume()
     }
+
     override fun onStart() {
         super.onStart()
         Log.e("Lifecycle", "HomeFragment onStart()")

diff --git a/app/src/main/java/com/example/TPSIMobileProjecto/ui/home/HomeViewModel.kt b/app/src/main/java/com/example/TPSIMobileProjecto/ui/home/HomeViewModel.kt
diff --git a/...java/com/example/TPSIMobileProjecto/ui/home/stockFragments/checklist/ChecklistFragment.kt b/...java/com/example/TPSIMobileProjecto/ui/home/stockFragments/checklist/ChecklistFragment.kt
@@ -7,7 +7,6 @@ import android.util.Log
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import android.view.ViewStub
 import android.widget.Button
 import android.widget.EditText
 import android.widget.ProgressBar

diff --git a/...a/com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleCardViewModel.kt b/...a/com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleCardViewModel.kt
diff --git a/...n/java/com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleFragment.kt b/...n/java/com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleFragment.kt
@@ -1,7 +1,6 @@
 package com.example.TPSIMobileProjecto.ui.home.stockFragments.simpleCard
 
 import android.content.Context
-import androidx.lifecycle.ViewModelProvider
 import android.os.Bundle
 import android.util.Log
 import androidx.fragment.app.Fragment
@@ -21,7 +20,6 @@ import retrofit.TickerSummary
 
 class SimpleCardFragment(watchList : MutableList<TickerSummary>, isFromWatchList : Boolean) : Fragment(), SimpleRecyclerAdapter.DetailedViewOnClick {
     val watchList = watchList
-    private lateinit var viewModel: SimpleCardViewModel
     val isFromWatchlist = isFromWatchList
     private lateinit var emptyListStub : ViewStub
 
@@ -35,7 +33,6 @@ class SimpleCardFragment(watchList : MutableList<TickerSummary>, isFromWatchList
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         Log.e("Lifecycle", "SimpleFragment onViewCreated()")
-        viewModel = ViewModelProvider(this).get(SimpleCardViewModel::class.java)
         emptyListStub = requireView().findViewById(R.id.simpleFragment_null_handle_list)
 
         if (watchList.isEmpty() && !isFromWatchlist){

diff --git a/...com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleRecyclerAdapter.kt b/...com/example/TPSIMobileProjecto/ui/home/stockFragments/simpleCard/SimpleRecyclerAdapter.kt
@@ -9,7 +9,6 @@ import android.widget.TextView
 import androidx.core.content.ContextCompat
 import androidx.recyclerview.widget.RecyclerView
 import com.example.TPSIMobileProjecto.R
-import com.example.TPSIMobileProjecto.ui.home.stockFragments.checklist.ChecklistRecyclerAdapter
 import com.squareup.picasso.Picasso
 import retrofit.TickerSummary