Pcvl 851 use masks when computing with state vectors #561
+120
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applies a threshold to filter low probability outcomes
AliseeNguyen
approved these changes
Mar 10, 2025
| @@ -611,6 +621,8 @@ def evolve_density_matrix(self, dm: DensityMatrix) -> DensityMatrix: | |||
| :param dm: The density Matrix to evolve | |||
| :return: The evolved DensityMatrix | |||
| """ | |||
| self._backend.clear_mask() # TODO: do it only if mask was set | |||
There was a problem hiding this comment.
There is still a TODO, maybe you wanted to do it in this PR ?
There was a problem hiding this comment.
I was planning to do it later as I will most probably need to change the workflow of the masks in PCVL-853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.