Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API wrapper #525

Merged
merged 27 commits into from
Jan 10, 2025
Merged

Remove API wrapper #525

merged 27 commits into from
Jan 10, 2025

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Dec 26, 2024 •
edited
Loading

This refactor resolves #521 by removing ApiWrapper and replacing its functionality with Engine.

The emoji dependency is also removed because it appears that most, if not all, assistants send unicode emojis instead of markdown emojis.

pmeier
pmeier reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good William. I left some comments.

ragna/deploy/_ui/central_view.py Outdated Show resolved Hide resolved
ragna/deploy/_engine.py Outdated Show resolved Hide resolved
ragna/deploy/_engine.py Outdated Show resolved Hide resolved
@smokestacklightnin smokestacklightnin marked this pull request as ready for review January 9, 2025 01:04
@smokestacklightnin smokestacklightnin marked this pull request as draft January 9, 2025 01:04
@smokestacklightnin
Copy link
Contributor Author

@pmeier How would you like me to handle this mypy failure?

@smokestacklightnin
Copy link
Contributor Author

@pmeier How would you like me to handle this mypy failure?

@pmeier I typecasted it

@smokestacklightnin smokestacklightnin marked this pull request as ready for review January 10, 2025 05:20
pmeier
pmeier approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks William. Minor comments left. You can self merge when addressed.

ragna/deploy/_ui/left_sidebar.py Outdated Show resolved Hide resolved
ragna/deploy/_ui/main_page.py Outdated Show resolved Hide resolved
@smokestacklightnin smokestacklightnin merged commit 6e9a45c into Quansight:main Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove API wrapper
2 participants
@smokestacklightnin @pmeier