Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Namespaces, use Globals #11

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Feb 21, 2024

Description

  1. Rename namespace QuantConnect.IQFeed -> QuantConnect.DataSource.IQFeed
  2. Rename: DataQueueHandler -> DataProvider
  3. Use Globals for credentials access for subscription validation.
    This follows Consolidate Configuration.Get usages Lean#7796
  4. Handle history provider returning null
    This follows Handle history provider returning null Lean#7804
  5. Handle data downloader provider returning null
    This follows feat: downloader data provider returning null Lean#7812

Related Issue

N/A

Motivation and Context

It keeps unify format like in another Data Sources.

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Leaving some comments

QuantConnect.IQFeed/IQFeedDataProvider.cs Outdated Show resolved Hide resolved
QuantConnect.IQFeed/IQFeedDataProvider.cs Outdated Show resolved Hide resolved
QuantConnect.IQFeed/IQFeedDataDownloader.cs Outdated Show resolved Hide resolved
QuantConnect.IQFeed/IQFeedDataDownloader.cs Outdated Show resolved Hide resolved
@Romazes Romazes requested a review from jhonabreul February 26, 2024 14:41
@Martin-Molinero Martin-Molinero merged commit f2d339b into QuantConnect:master Feb 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants