Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Project Structure and Clean Unused Libraries #4

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Jan 22, 2024

Description

This pull request aims to enhance the project by performing a comprehensive refactoring of the solution. The changes include renaming all projects within the solution, updating folder paths, and refining project names. Additionally, namespace modifications have been made for improved consistency and clarity. In the final step, any unused libraries across all files have been identified and removed to optimize the codebase.

Related Issue

N/A

Motivation and Context

The motivation behind this refactor is to establish a more organized and coherent project structure. By renaming projects and adjusting folder paths, the codebase becomes more intuitive and easier to navigate. Consistent naming conventions in namespaces contribute to better code readability and maintainability. The removal of unused libraries ensures a leaner project, reducing potential conflicts and enhancing overall performance.

Requires Documentation Change

N/A

How Has This Been Tested?

The changes have been thoroughly tested across various scenarios to ensure the refactoring does not introduce any regressions. Unit tests have been executed to validate the correctness of the code after the renaming and removal of unused libraries. Integration tests have been performed to guarantee the compatibility of the refactored code with the overall system. Manual testing was carried out to identify any potential issues not covered by automated tests. The project has been built and run successfully to confirm the stability of the updated codebase.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

rename: namespaces by appropriate project names
fix: path in workflow file
clean: not used libraries in files
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@Martin-Molinero Martin-Molinero merged commit 9c695ee into QuantConnect:master Jan 22, 2024
1 check passed
@Romazes Romazes deleted the feature-rename-projects-folders-structure branch February 1, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants