-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup QuantEcon-wasm library #1
Conversation
Locally all the tests are passing:
One of the tests is failing and is known to me. It's marked with |
@kp992 I will dive into this error on Thur/Fri this week. |
@kp992 an Looks like tolerances are different
|
Thanks @mmcky for checking that. Are they failing on your local machine too? |
Ah, I get it. My local machine was using numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kp992 - it will be interesting to start benchmarking the wasm and non-wasm versions via the test cases :-)
dynamic = ["description", "version"] | ||
requires-python = ">=3.7" | ||
dependencies = [ | ||
'numpy>=1.17.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kp992 does this need to be numpy >= 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thanks. Nice catch!
@kp992 happy for me to merge this? or want to make that change first? |
sure, lets merge this. |
Setup QuantEcon-wasm library. This PR mirrors the original QuantEcon.py library and removes numba dependency for WASM environments.