Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use map instead of applymap #330

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Use map instead of applymap #330

merged 3 commits into from
Apr 3, 2024

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Dec 28, 2023

Fixes #325

A new anaconda==2024.02 uses pandas==2.1.4

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 3487e42
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/660cd6ecda7fa1000951be01
😎 Deploy Preview https://deploy-preview-330--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kp992
Copy link
Contributor Author

kp992 commented Dec 28, 2023

I see the failures because of pandas version on CI is 2.0.3 and this change require > 2.1.

@jstac
Copy link
Contributor

jstac commented Feb 6, 2024

Hi @mmcky , do you think we can merge this now? pandas is at 2.1 in Anaconda.

@mmcky
Copy link
Contributor

mmcky commented Feb 12, 2024

Hi @mmcky , do you think we can merge this now? pandas is at 2.1 in Anaconda.

@jstac the issue is that pandas in anaconda==2023.09 is still at pandas==2.0.3 so a fresh anaconda install will still fail.

anaconda 2023.09 package list

Once the next anaconda is released we should be able to merge this.

You can fetch a later pandas from conda but it isn't bundled.

@mmcky mmcky added the future label Feb 12, 2024
lectures/inflation_history.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 3, 2024

@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 04:19 Inactive
@mmcky
Copy link
Contributor

mmcky commented Apr 3, 2024

thanks @kp992

@mmcky mmcky merged commit fa191ae into main Apr 3, 2024
6 checks passed
@mmcky mmcky deleted the i325 branch April 3, 2024 04:23
@kp992
Copy link
Contributor Author

kp992 commented Apr 3, 2024

Thank you for finishing the PR @mmcky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of DataFrame.applymap
3 participants