-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Migrated Lecture ar1_processes
#385
Conversation
ar1_processes
and scalar_dynam
)
@HumphreyYang I am not sure what you mean by template? (a process?) We will want to also setup a redirect using
|
I remembered that we have a small admonition at the top that says the lecture has been migrated and will be taken down after a month. Please correct me if I were wrong. |
Next Steps
Once the new locations are live and published
|
I found it for the heavy_tails lecture. I will put this in place now. |
thanks @HumphreyYang. I guess we need to choose if we |
Actually - let's give this a go. We will need to:
|
Many thanks @mmcky, I think it is a better design choice. Readers cannot see the migration notice for the heavy_tail lecture as they are redirected to the new page : ) |
We couldn't have both as the |
Many thanks @mmcky, I just ran a diff and found one section is deleted in the intro version. Perhaps we should leave it for now, and I will consult John in our next meeting. |
ar1_processes
and scalar_dynam
)ar1_processes
The warnings are complaining about the missing We should get green ticks once |
@HumphreyYang this lecture is now live |
@HumphreyYang I have added the redirect for the |
@HumphreyYang well this is interesting. Are these the warnings to showed up last time?
|
thanks @HumphreyYang yeah there definitely seems to be an issue using both I know I am surprised though as inter sphinx is using a domain so should be independent. Will have to figure this one out. |
Many thanks @mmcky, I experimented removing the tag or adding an empty ar1_processes but no luck. I was also thinking about its implications on our new series. I think we can prioritize intersphinx in our new lecture series as we might be able to create an empty repository (with only the config file) hosting the redirect mappings between old intermediate series and new series. In this case, we do not have internal intersphinx references in the redirect repository, and intersphinx will also work in our new series. |
Thanks @HumphreyYang I don't fully understand what you are proposing. Can you explain? We will need page redirection support to make sure anyone with |
Many thanks @mmcky I am not sure whether it will work but I am proposing to have a fresh repository with old intermediate series URL. It will host the redirect config and intro page only (without lectures). In this case, it wouldn’t conflict with intersphinx since lectures are hosted in our target repositories. Please let me know your thoughts on this. |
@HumphreyYang are you replicating this locally -- I can't so the mystery depends. I have triggered a new build run to confirm. |
Yes, I can replicate this locally. I will have another go today. |
@HumphreyYang I am definitely getting no local build errors for either |
@HumphreyYang the error still persists without ca5a20a so maybe |
@HumphreyYang I think I have figure this out 🤞 -- I think the settings are misspecified in the context of the |
@HumphreyYang I am rebuilding the cache to check there isn't some form of corruption. |
@HumphreyYang no idea why cdf81e8 built OK when the cache hasn't finihsed rebuilding yet. Clearly some instability. I will re-run this once cache is finalised to check all is green after that. |
@HumphreyYang I think this is working nicely now. |
Hi @mmcky,
This PR removes lectures that have been migrated to the intro series (QuantEcon/lecture-python-intro#334).
The AR(1) lecture is now in lecture-python-intro/pull/335
Do we still have a template for the migrated lecture? Apologize that I cannot find the template anymore in the commit thread.