-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cox Objective #464
Comments
Absolutely. This is not on the radar in the short term, but a PR is very welcome if you want to take a shot at it. |
Great -- I just might! |
I thought of giving this a shot, but first we need to clarify something: the Cox partial likelihood is not an EDM. The solvers in glum are built around the EDM assumption, so I don't see how we can easily incorporate this objective. A Cox Proportional Hazard can be estimated with a Poisson GLM via a data transformation. The Cox objective is equivalent to the Poisson likelihood with a fixed effect for each event time and this fixed effect profiled out, see an explanation here). The transformation is to cut the observation into small subperiods, corresponding to event occurrences (in R, this is survSplit). Is such a data transformation a useful addition to glum or is this too far removed from the core functionality? @MarcAntoineSchmidtQC @tbenthompson |
Useful for discrete time survival models. Somewhat related to #464. More info: https://grodri.github.io/glms/notes/c7s6
Useful for discrete time survival models. Somewhat related to #464. More info: https://grodri.github.io/glms/notes/c7s6
Useful for discrete time survival models. Somewhat related to #464. More info: https://grodri.github.io/glms/notes/c7s6
* Add cloglog link function Useful for discrete time survival models. Somewhat related to #464. More info: https://grodri.github.io/glms/notes/c7s6 * Improve numerical accuracy * Fix tests (restrict test values) * Add 'cloglog' to `GeneralizedLinearRegressor` opts * Add changelog entry * Apply suggestions from code review Fix docstrings Co-authored-by: Luca Bittarello <[email protected]> * Add test cloglog test against other packages --------- Co-authored-by: Luca Bittarello <[email protected]>
Would there be any interest in the addition of the Cox Proportional Hazards loss for modeling survival data?
The text was updated successfully, but these errors were encountered: