Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on how to estimate a Cox Proportional Hazards Model in glum #876

Merged
merged 22 commits into from
Nov 6, 2024

Conversation

MatthiasSchmidtblaicherQC
Copy link
Contributor

@MatthiasSchmidtblaicherQC MatthiasSchmidtblaicherQC commented Nov 1, 2024

And: Add link to Matt Mills' tutorial on fitting penalized splines in glum.

Checklist

  • Added a CHANGELOG.rst entry

@MatthiasSchmidtblaicherQC MatthiasSchmidtblaicherQC linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link
Collaborator

@stanmart stanmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matthias, I like this tutorial a lot!

Maybe we could also mention that the model we estimate is conceptually a piecewise constant hazard model, but because we have a different constant for each event time, it becomes essentially non-parametric. As a corollary, if one wants to reduce the number of parameters, they can opt for merging some categories and estimating fewer "constants".

@MatthiasSchmidtblaicherQC
Copy link
Contributor Author

Thank you Matthias, I like this tutorial a lot!

Maybe we could also mention that the model we estimate is conceptually a piecewise constant hazard model, but because we have a different constant for each event time, it becomes essentially non-parametric. As a corollary, if one wants to reduce the number of parameters, they can opt for merging some categories and estimating fewer "constants".

Thanks! I incorporated your suggestion and added a small conclusion section describing how one might want to depart from the Cox model. Feel free to have another look :).

@MatthiasSchmidtblaicherQC MatthiasSchmidtblaicherQC merged commit 245d8b3 into main Nov 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference to blog post on penalized splines in docs Add Cox Objective
2 participants