Compatibility with narwhals-based tabmat #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcAntoineSchmidtQC let me know your thoughts about the duplicate column name issue. |
|
adding narwhals to the "build-tabmat" group is good with me. Regarding the duplicate columns, I think this was an issue with some of the logic. I agree that we should fix the benchmark dataset to not have duplicate names. We should also verify that we are giving an informative error message when this happens. Thanks for taking care of this! |
stanmart
requested review from
MarcAntoineSchmidtQC,
jtilly and
lbittarello
as code owners
We should do this in tabmat, right? |
10 tasks
|
Thanks for the amazingly quick update @MarcoGorelli! 🙏 @MarcAntoineSchmidtQC, we can then merge this as is, right? |
jtilly
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentryAims to fix #867.
--no-deps. This PR adds narwhals to the nightlies environment, but not the main one (where will be pulled in as a transitive dependency).tabmat.from_pandas/dfnow does not accept dataframes which have non-unique column names. This was an unintentended consequence of switching to narwhals, but I think it's probably for the best. Unfortunately many of our golden master benchmarks do have duplicate columns. I think the best way to go would be to fix the benchmark datasets, but let me know if you'd rather allow duplicate column names (in which case the fix should be on the tabmat side).