Run the CI unit tests on external pull requests #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanmart
requested review from
MarcAntoineSchmidtQC,
jtilly and
lbittarello
as code owners
|
Eh, this is not the solution because it will duplicate checks. What about only running the CI on pull requests and pushes to main? Although that would mean that working branches do not have CI. Or maybe leave everything as is and remember to check the source repo of external PRs? :) |
|
Thanks, that looks good. I'll even steal Kevin's detailed comments. The slight issue remains that the CI won't run until we open a PR, but that's fine with me. |
jtilly
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentry