-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pixi and support windows #1
Conversation
- name: Publish package on TestPyPi | ||
uses: pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450 | ||
with: | ||
repository-url: https://test.pypi.org/legacy/ | ||
- name: Publish package on PyPi | ||
uses: pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Pavel Zwerschke <[email protected]>
Co-authored-by: Pavel Zwerschke <[email protected]>
Co-authored-by: Pavel Zwerschke <[email protected]>
96b1c49
to
ad0f757
Compare
README.md
Outdated
|
||
# Set up development environment | ||
pixi shell | ||
pre-commit install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't always work since pre-commit
is not part of the default env. why not use pixi run pre-commit-install
which automatically uses the lint
env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough - wanted to keep the set up familiar to non pixi users. I think I'll create a dev env with everything bundled into it.
README.md
Outdated
pre-commit install | ||
pip install --no-build-isolation -e . | ||
pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will use build isolation, i.e. use setuptools-scm outside of the pixi environment. you would need --no-build-isolation
for this. Also, you should specify --no-deps
to not use pypi dependencies from pyproject.toml
and instead use the conda dependencies from your pixi environment
pyproject.toml
Outdated
[tool.pixi.project] | ||
channels = ["conda-forge"] | ||
platforms = ["osx-arm64"] | ||
|
||
[tool.pixi.pypi-dependencies] | ||
ndonnx = { path = ".", editable = true } | ||
|
||
[tool.pixi.tasks] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should specify these things in pixi.toml
(or use pyproject.toml
solely). also, i wouldn't recommend ndonnx = { path = ".", editable = true }
as of now: prefix-dev/pixi#1046
f6931d2
to
157c865
Compare
a80f69b
to
6d2d82a
Compare
4c3e61e
to
734b2eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my few comments this looks good to me
Checklist
CHANGELOG.rst
entry