-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce internal interface for ValuePropBackend
#202
Open
neNasko1
wants to merge
14
commits into
Quantco:main
Choose a base branch
from
neNasko1:value-prop-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
neNasko1
requested review from
adityagoel4512,
cbourjau and
jbachurski
as code owners
January 21, 2025 02:52
1 task
Signed-off-by: Atanas Dimitrov <[email protected]>
Signed-off-by: Atanas Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #201 because of missing access to the repo
Since we currently "bless" the reference and onnxruntime implementations as the only way to propagate value internally, this PR refactors a bit the internals to allow a better interface for "custom" execution providers(i.e. @cbourjau rust runtime, onnx-mlir...).
Consult the tests for a POC which could also be used to register custom opsets as well.
Checklist
CHANGELOG.rst
entry