Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haah's cubic code using abelian group ℤ₃ˣ³ via Hecke's Group Algebra #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 10, 2024

This PR aims to implement Haah's cubic code, a cousin of Generalized Bicycle code as mentioned in https://errorcorrectionzoo.org/c/generalized_bicycle.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (2b8e81f) to head (86e622f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   83.03%   83.01%   -0.03%     
==========================================
  Files          70       70              
  Lines        4404     4409       +5     
==========================================
+ Hits         3657     3660       +3     
- Misses        747      749       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz Fe-r-oz marked this pull request as draft October 11, 2024 04:45
@Fe-r-oz Fe-r-oz marked this pull request as ready for review October 11, 2024 09:11
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 11, 2024

I think this is ready for review, @Krastanov. Thanks!

Brief context: For GB codes , n%l+1 is used for GroupAlgebra (GA) indexing to indicate the cyclic nature for single cyclic group. This is same as doing n%dim(GA)+1. This works as here, we have a single cyclic group of order l, so total order is l which can be acquired using dim(GA).

In Haah cubic code case, the total order is , hence using n%dim(GA)+1 is appropriate since dim(GA) would give because here, direct product of three cyclic groups ( total order = lxlxl) is the requirement. Also, The CI errors are unrelated to this PR.

Edit:

For large values of l, there are some crashes due to huge cubic lattice, GA with sparse representation is being worked on by Tommy here: thofma/Hecke.jl#1655. I will add this functionality once available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant