Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the feature to prohibit starting of a qube #658

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add the feature to prohibit starting of a qube #658

merged 1 commit into from
Feb 21, 2025

Conversation

alimirjamali
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (2069b1d) to head (5de215d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/qubesvm.py 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   69.74%   69.79%   +0.04%     
==========================================
  Files          58       58              
  Lines       12542    12546       +4     
==========================================
+ Hits         8748     8756       +8     
+ Misses       3794     3790       -4
Flag Coverage Δ
unittests 69.79% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marmarek
marmarek requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please also add a tests. Since unit test may require mocking most of the start method, it can be in integration tests (for example qubes/tests/integ/basic.py)

@alimirjamali alimirjamali force-pushed the issue-9622 branch 3 times, most recently from 8468465 to 1331956 Compare February 19, 2025 10:10
This was referenced Feb 20, 2025
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Feb 20, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025022106-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_kde_gui_interactive

  • system_tests_audio

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_misc

    • TC_06_AppVM_debian-12-xfce: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_fedora-41-xfce: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_whonix-gateway-17: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_whonix-workstation-17: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_30_Gui_daemon: test_000_clipboard (error)
      FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_gui_tools

    • qui_widgets_update: unnamed test (unknown)
    • qui_widgets_update: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-updates-widget-op...

Failed tests

26 failures

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...

  • system_tests_audio

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_misc

    • TC_06_AppVM_debian-12-xfce: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_fedora-41-xfce: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_whonix-gateway-17: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

    • TC_06_AppVM_whonix-workstation-17: test_020_custom_persist (failure)
      AssertionError: Too much / too little files persisted: b'test1\ntes...

  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_30_Gui_daemon: test_000_clipboard (error)
      FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_gui_tools

    • qui_widgets_update: unnamed test (unknown)
    • qui_widgets_update: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qui-updates-widget-op...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/127852#dependencies

28 fixed

  • system_tests_suspend

    • mount_and_boot_options: unnamed test (unknown)
    • mount_and_boot_options: Failed (test died)
      # Test died: no candidate needle with tag(s) 'x11' matched...

  • system_tests_backup

    • TC_10_BackupVM_whonix-gateway-17: test_110_send_to_vm_no_space (error)
      subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...

    • TC_10_BackupVM_whonix-workstation-17: test_110_send_to_vm_no_space (error)
      subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...

  • system_tests_qrexec

  • system_tests_dispvm

    • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
      AssertionError: './open-file test.txt' failed with ./open-file test...

  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_000_list_loop (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_010_list_dm (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_012_list_dm_delayed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_013_list_dm_removed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_020_list_loop_partition (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-gateway-17: test_021_list_loop_partition_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_000_list_loop (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_001_list_loop_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_010_list_dm (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_011_list_dm_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_012_list_dm_delayed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_013_list_dm_removed (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_020_list_loop_partition (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_00_List_whonix-workstation-17: test_021_list_loop_partition_mounted (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_10_Attach_whonix-gateway-17: test_000_attach_reattach (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

    • TC_10_Attach_whonix-workstation-17: test_000_attach_reattach (error)
      subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...

  • system_tests_kde_gui_interactive

  • system_tests_qrexec_perf@hw1

    • TC_00_QrexecPerf_debian-12-xfce: test_110_simple_data_duplex (failure)
      AssertionError: '/usr/lib/qubes/tests/qrexec_perf.py --vm1=test-ins...

  • system_tests_storage_perf@hw1

    • integ: storage_perf (error)
      ModuleNotFoundError: No module named 'qubes.tests.integ.storage_perf'

  • system_tests_basic_vm_qrexec_gui_ext4

    • switch_pool: Failed (test died)
      # Test died: command 'printf "label: gpt\n,,L" | sfdisk /dev/sdb' f...

Unstable tests

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

72 tests
  • debian-12-xfce_exec: 7.28
  • debian-12-xfce_exec-root: 28.07
  • debian-12-xfce_socket: 8.60
  • debian-12-xfce_socket-root: 8.33
  • debian-12-xfce_exec-data-simplex: 45.25
  • debian-12-xfce_exec-data-duplex: 48.08
  • debian-12-xfce_exec-data-duplex-root: 63.67
  • debian-12-xfce_socket-data-duplex: 78.28
  • fedora-41-xfce_exec: 9.12 🟢 ( previous job: 21.67, improvement: 42.09%)
  • fedora-41-xfce_exec-root: 60.32 🟢 ( previous job: 74.48, improvement: 80.99%)
  • fedora-41-xfce_socket: 8.24 🟢 ( previous job: 21.26, improvement: 38.78%)
  • fedora-41-xfce_socket-root: 8.41 🟢 ( previous job: 20.89, improvement: 40.27%)
  • fedora-41-xfce_exec-data-simplex: 46.16 🟢 ( previous job: 58.71, improvement: 78.63%)
  • fedora-41-xfce_exec-data-duplex: 47.15 🟢 ( previous job: 60.49, improvement: 77.94%)
  • fedora-41-xfce_exec-data-duplex-root: 81.31 🟢 ( previous job: 92.13, improvement: 88.25%)
  • fedora-41-xfce_socket-data-duplex: 79.46 🟢 ( previous job: 83.57, improvement: 95.08%)
  • whonix-gateway-17_exec: 7.15
  • whonix-gateway-17_exec-root: 38.05
  • whonix-gateway-17_socket: 8.14
  • whonix-gateway-17_socket-root: 7.64
  • whonix-gateway-17_exec-data-simplex: 46.63
  • whonix-gateway-17_exec-data-duplex: 51.78
  • whonix-gateway-17_exec-data-duplex-root: 71.74
  • whonix-gateway-17_socket-data-duplex: 83.41
  • whonix-workstation-17_exec: 8.10
  • whonix-workstation-17_exec-root: 52.21
  • whonix-workstation-17_socket: 7.84
  • whonix-workstation-17_socket-root: 7.97
  • whonix-workstation-17_exec-data-simplex: 48.98
  • whonix-workstation-17_exec-data-duplex: 48.66
  • whonix-workstation-17_exec-data-duplex-root: 80.03
  • whonix-workstation-17_socket-data-duplex: 82.07
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 448684.00
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 182617.00
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 423495.00
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 143300.00
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 11444.00
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5071.00
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 6067.00
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4353.00
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 462539.00
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 139764.00
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 432580.00
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 196459.00
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 108532.00
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 8503.00
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 5566.00
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3308.00
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 398849.00
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 103187.00
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 358487.00
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 36090.00
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 87805.00
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3144.00
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8520.00
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1434.00
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 385081.00
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 116220.00
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 339125.00
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 50474.00
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 94021.00
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 1459.00
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8882.00
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 892.00
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 420439.00
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 235953.00
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 346407.00
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 96306.00
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 87623.00
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 5369.00
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8541.00
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1908.00

This was referenced Feb 20, 2025
Open
Merged
Merged
Merged
Merged
@marmarek marmarek merged commit 5de215d into QubesOS:main Feb 21, 2025
3 of 5 checks passed
This was referenced Feb 21, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmarek marmarek marmarek approved these changes

Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a feature to block starting a qube
3 participants
@alimirjamali @qubesos-bot @marmarek